Fix multimodal warmup #1465
Open
Fix multimodal warmup #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
adobrzyn
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz-intel,
vivekgoe,
afierka-intel,
xuechendi,
jikunshang and
mswiniarsk
as code owners
|
/run-gaudi-tests |
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the multimodal warmup process by removing the available_mem parameter and its related memory check logic to adjust how memory usage is accounted during warmup.
- Removed the available_mem parameter from _warmup_multimodal_graph.
- Eliminated the memory check based on available_mem and its decrement logic during warmup.
Comments suppressed due to low confidence (2)
vllm/worker/hpu_model_runner.py:2763
- The available_mem parameter was removed from _warmup_multimodal_graph. Please confirm that any necessary memory limiting logic is now handled elsewhere and update related documentation or comments accordingly.
kv_caches,
vllm/worker/hpu_model_runner.py:2793
- By removing the decrement of available_mem, the memory usage accounting strategy has changed. Ensure that this adjustment is intentional and that any required memory usage checks are implemented elsewhere in the code.
torch.distributed.ReduceOp.MAX)
madamczyk-intel
approved these changes
Jun 23, 2025
|
/run-gaudi-tests |
1 similar comment
|
/run-gaudi-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.